Optimization of nearest location transfer for nearest-subapp #28785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
commented
Oct 6, 2024
GiudGiud
commented
Oct 6, 2024
framework/src/transfers/MultiAppGeneralFieldNearestLocationTransfer.C
Outdated
Show resolved
Hide resolved
GiudGiud
commented
Oct 6, 2024
framework/src/transfers/MultiAppGeneralFieldNearestLocationTransfer.C
Outdated
Show resolved
Hide resolved
- only use the minimal number of KDTree (# local apps) rather than the number of positions (global #of apps) refs idaholab#23585 Apply suggestions from code review
Add a special case bypassing bounding boxes for nearest-app mode to determine the source processors refs idaholab#28782
|
Job Documentation, step Docs: sync website on 328eeff wanted to post the following: View the site here This comment will be updated on new commits. |
…oner Avoid ignoring user parameters when they dont match the number of MPI closes idaholab#28787
- add an automatic option, for each level - make sure we can constrain the selections
loganharbour
reviewed
Oct 7, 2024
| positions_array[int(float(i) / n_positions * n_bins)].push_back(positions[i]); | ||
|
|
||
| if (n_bins > n_positions) | ||
| mooseError("Not implemented for more MPI processes than positions"); |
There was a problem hiding this comment.
probably a good use for the documented error?
… with heuristics for trying to get even bin sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the nearest-position mode (which could cover nearest-subapp) was taking a big hit on performance on cases with very many subapps, because it was creating a KDtree for every (global) sub-app
This fixes that problem, and adds minor other optimizations for speed & scalability
PR has ballooned to include: