Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Amir Mohammadi as contributor in multiple files since git history is lost #13

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

183amir
Copy link
Collaborator

@183amir 183amir commented Oct 25, 2024

Since this package was renamed from bob.extension to clapper, Amir's contributions to these files were lost. Amir was a major contributer to bob.extension: https://gitlab.idiap.ch/bob/bob.extension/-/graphs/master?ref_type=heads This commit lists Amir as a contributer on multiple files to remedy this issue.


📚 Documentation preview 📚: https://clapper--13.org.readthedocs.build/en/13/

…history is lost

Since this package was renamed from bob.extension to clapper, Amir's contributions to these files were lost.
Amir was a major contributer to bob.extension: https://gitlab.idiap.ch/bob/bob.extension/-/graphs/master?ref_type=heads
This commit lists Amir as a contributer on multiple files to remedy this issue.
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/clapper
  click.py
  config.py
  rc.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@Yannick-Dayer Yannick-Dayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the move to GitHub squashed all the commits into one, losing the authorship of the files.

@183amir 183amir merged commit a856ae2 into main Nov 5, 2024
10 checks passed
@183amir 183amir deleted the add-amir-as-contributer branch November 5, 2024 11:10
@183amir
Copy link
Collaborator Author

183amir commented Nov 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants