Merge pull request #5 from idiap/ruff

Switch to ruff and pyproject.toml, drop Python 3.8

.github/workflows/pypi-release.yml

@@ -14,9 +14,9 @@ jobs:
       - name: Verify tag matches version
         run: |
           set -ex
-          version=$(cat trainer/VERSION)
+          version=$(grep -m 1 version pyproject.toml | grep -P '\d+\.\d+\.\d+' -o)
           tag="${GITHUB_REF/refs\/tags\/}"
-          if [[ "$version" != "$tag" ]]; then
+          if [[ "v$version" != "$tag" ]]; then
             exit 1
           fi
       - uses: actions/setup-python@v5
@@ -36,7 +36,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
@@ -67,10 +67,6 @@ jobs:
         with:
           name: "sdist"
           path: "dist/"
-      - uses: actions/download-artifact@v4
-        with:
-          name: "wheel-3.8"
-          path: "dist/"
       - uses: actions/download-artifact@v4
         with:
           name: "wheel-3.9"

.github/workflows/style_check.yml

@@ -28,13 +28,8 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y git make gcc
-          make system-deps
-      - name: Install/upgrade Python setup deps
-        run: python3 -m pip install --upgrade pip setuptools wheel
-      - name: Install Trainer
-        run: |
-          python3 -m pip install .[all]
-          python3 setup.py egg_info
+      - name: Install/upgrade dev dependencies
+        run: python3 -m pip install -r requirements.dev.txt
       - name: Lint check
         run: |
           make lint

.github/workflows/tests.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
+        python-version: [3.9, "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python ${{ matrix.python-version }}
@@ -28,12 +28,37 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y --no-install-recommends git make gcc
-          make system-deps
       - name: Install/upgrade Python setup deps
         run: python3 -m pip install --upgrade pip setuptools wheel
       - name: Install Trainer
         run: |
-          python3 -m pip install .[all]
-          python3 setup.py egg_info
+          python3 -m pip install .[dev,test]
       - name: Unit tests
         run: make test_all
+      - name: Upload coverage data
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-data-${{ matrix.python-version }}
+          path: .coverage.*
+          if-no-files-found: ignore
+  coverage:
+    if: always()
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - uses: actions/download-artifact@v4
+        with:
+          pattern: coverage-data-*
+          merge-multiple: true
+      - name: Combine coverage
+        run: |
+          python -Im pip install --upgrade coverage[toml]
+
+          python -Im coverage combine
+          python -Im coverage html --skip-covered --skip-empty
+
+          python -Im coverage report --format=markdown >> $GITHUB_STEP_SUMMARY

.pre-commit-config.yaml

@@ -0,0 +1,20 @@
+repos:
+  - repo: "https://github.com/pre-commit/pre-commit-hooks"
+    rev: v4.6.0
+    hooks:
+      - id: check-yaml
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.4.10
+    hooks:
+      - id: ruff
+        args: [--fix, --exit-non-zero-on-fix]
+      - id: ruff-format
+  - repo: local
+    hooks:
+      - id: generate_requirements.py
+        name: generate_requirements.py
+        language: system
+        entry: python bin/generate_requirements.py
+        files: "pyproject.toml|requirements.*\\.txt|tools/generate_requirements.py"