Fix type hint and run CI on highest+lowest dependency versions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
force-pushed
the
test-lowest
branch
3 times, most recently
from
449d31d
to
572e698
Compare
eginhard
force-pushed
the
test-lowest
branch
2 times, most recently
from
ae5d83e
to
bf99927
Compare
Tests run fast enough that this is fine
torch.amp.GradScaler is only available from Pytorch 2.3
eginhard
changed the title
KarlHajal
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.amp.GradScalerused in type hints is available only from Pytorch 2.3,torch.amp.cuda.GradScalercan be used instead.To avoid similar issues in the future, we now use uv to run the CI on both the lowest and highest supported versions of dependencies.