Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved some stuff from setup.py into pyproject.toml #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KOLANICH
Copy link
Contributor

And improved stuff in setup.py a bit

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see [this][commit messages] for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage increased (+0.01%) to 91.044% when pulling 9e2ff9d on UniGrammar:pyproject.toml into 510318f on igordejanovic:master.

@igordejanovic
Copy link
Owner

@KOLANICH Not sure how is this supposed to work? How do you build a package with this change?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 4, 2020

setuptools has one of entry_points used as a hook for other tools, setuptools_scm uses it. Should work out of the box as usual.

@igordejanovic
Copy link
Owner

Did you tried it? What command do you use to build wheel and source distributions?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 5, 2020

Did you tried it?

In fact I haven't tried building parglare for a while (it is installed with -e for me), for other my tools I use the similar setuptools_scm config in pyproject.toml since support of this has been released.

What command do you use to build wheel and source distributions?

As usual python3 ./setup.py bdist_wheel, but python3 -m pep517.build (the new build-backend-independent command) should work too. What does it write for you?

@igordejanovic
Copy link
Owner

As usual python3 ./setup.py bdist_wheel, but python3 -m pep517.build (the new build-backend-independent command) should work too. What does it write for you?

python setup.py bdist_wheel doesn't pick up version correctly and produces package parglare-0.0.0-py2.py3-none-any.whl. python -m pep517.build does work after pip install pep517. Do you have any reference what is the recommended way to do builds and uploads to PyPI now?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 6, 2020

That's extremily strange. I have checked recently, on my machine everything works (I use python3 for building, python2 is EOL). Please make sure that the libs (setuptools and setuptools_scm) are of the latest versions (pyproject.toml should ensure that the versions are compatible though) and that tag is present on the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants