Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tiling #311

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Refactor tiling #311

merged 5 commits into from
Jan 24, 2024

Conversation

k-dominik
Copy link
Contributor

In order to make it easier to extend tiling and also track changes this PR separates Tiling and TileProvider classes.

The only addition here is the test for Data2Scene transformation in tiling.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (5d4d855) 36.30% compared to head (0cbc945) 36.28%.

Files Patch % Lines
volumina/tiling/tileprovider.py 76.89% 55 Missing ⚠️
volumina/tiling/tiling.py 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   36.30%   36.28%   -0.02%     
==========================================
  Files         106      108       +2     
  Lines       11492    11489       -3     
==========================================
- Hits         4172     4169       -3     
  Misses       7320     7320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k-dominik k-dominik marked this pull request as ready for review January 16, 2024 16:29
Copy link
Contributor

@btbest btbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't change any actual logic as far as I can tell so looks good. More tests are good tests as well.

@k-dominik k-dominik merged commit 8ed88f6 into ilastik:main Jan 24, 2024
12 of 13 checks passed
@k-dominik k-dominik deleted the refactor-tiling branch January 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants