Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export option for single-scale OME-Zarr #316

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

btbest
Copy link
Contributor

@btbest btbest commented Sep 18, 2024

Instead of adding a triplicate of the H5/N5 file options widget, I figured I'd combine them instead. Still pondering whether the one point of custom logic for zarr (allowing dataset to be empty) warrants a duplicate, but don't really think so. Not sure why it's mandatory anyway; there is ilastik code that enforces an internal path to be present for H5 but not N5.

I've put the menu option under the below hierarchical formats for now, but that's easy to relocate if we want to have it further up or down the list.

@btbest btbest mentioned this pull request Sep 18, 2024
6 tasks
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (baf0c13) to head (5292923).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ina/widgets/hierarchicalFileExportOptionsWidget.py 0.00% 18 Missing ⚠️
.../widgets/multiformatSlotExportFileOptionsWidget.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   36.58%   36.48%   -0.10%     
==========================================
  Files         108      107       -1     
  Lines       11489    11371     -118     
==========================================
- Hits         4203     4149      -54     
+ Misses       7286     7222      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@btbest btbest marked this pull request as ready for review September 27, 2024 12:29
@btbest btbest changed the title Ome zarr export Add export option for single-scale OME-Zarr Sep 27, 2024
Copy link
Contributor

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice refactor, too :) great to unify those things :). And less code, more functionality - you seem to have a knack for that 👍

Could've been rebased onto main before opening... (I thought darkmode was broken again...)

volumina/widgets/hierarchicalFileExportOptionsWidget.py Outdated Show resolved Hide resolved
@btbest
Copy link
Contributor Author

btbest commented Oct 8, 2024

Ready to merge when ilastik PR is done

@btbest btbest merged commit 7d58143 into ilastik:main Oct 15, 2024
11 of 13 checks passed
@btbest btbest deleted the ome-zarr-export branch October 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants