cleanup and linting for api #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcop
reviewed
Jan 2, 2019
Fast0n
force-pushed
the
master
branch
2 times, most recently
from
2d5fccd
to
7c96be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rifattorizzato un attimo le api, e strutturata con controller/router, dovrebbe permettere più facili revisioni nei singoli file ed eventualmente supporto di altri sviluppatori avendo inserito un linter per il codice.
Un solo dubbio, visto tutto gira in
GET, visto che ci sono credenziali di mezzo, non sarebbe meglio far sparire dagli access log i dati usando unaPOST?