Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #556 #558

Draft
wants to merge 67 commits into
base: nz-development
Choose a base branch
from

Conversation

tmfrnz
Copy link
Member

@tmfrnz tmfrnz commented May 28, 2024

No description provided.

@vbojilova
Copy link
Contributor

vbojilova commented Jun 5, 2024

commit 96424c8

  • Upgrade to styled components 6 causes mis-colouring in EntityListItemMainTaxonomies tags.

@@ -65,7 +65,7 @@ function Overlay({
<LayerContent flex={{ grow: 1 }}>
<div>
{markdown && (
<Markdown source={content} className="react-markdown" linkTarget="_blank" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbojilova what about the linkTarget option?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it causes this error: "react-dom.development.js:26957 Uncaught Assertion: Unexpected linkTarget prop, remove it"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but we should not change the functionality ... if it doesnt by default, I am sure there is an alternative way of achieving this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Good point! I re-added the functionality back in here c5d736c

@vbojilova
Copy link
Contributor

vbojilova commented Jun 13, 2024

Known issues:

  • go to create a new entity (e.g action) -> select a target date from the day picker -> save entity-> in the single page view for given new entity the date chosen is off by 1 day
  • mobile: explore button on intro page should be smaller size, not take up full width
  • Had to remove deprecated options from webpackDevMiddleware but now output is verbose, find how to silence/just output log for warnings. Old way code below:
webpackDevMiddleware(compiler, {
    logLevel: 'warn',
    silent: true,})

@vbojilova
Copy link
Contributor

vbojilova commented Jun 14, 2024

Commit 6900bbb needs global npm 10.5.0 and node 21.1.0

@vbojilova vbojilova changed the title updated dependencies that have no breaking code changes #556 updated dependencies #556 Jun 19, 2024
@vbojilova
Copy link
Contributor

vbojilova commented Jun 19, 2024

  • Had to downgrade eslint dev deps in c3b0d0a because of staging errors, will re-update next with lint config changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants