-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated dependencies #556 #558
base: nz-development
Are you sure you want to change the base?
Conversation
…ded styled components #556
commit 96424c8
|
@@ -65,7 +65,7 @@ function Overlay({ | |||
<LayerContent flex={{ grow: 1 }}> | |||
<div> | |||
{markdown && ( | |||
<Markdown source={content} className="react-markdown" linkTarget="_blank" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vbojilova what about the linkTarget option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it causes this error: "react-dom.development.js:26957 Uncaught Assertion: Unexpected linkTarget
prop, remove it"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but we should not change the functionality ... if it doesnt by default, I am sure there is an alternative way of achieving this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! Good point! I re-added the functionality back in here c5d736c
Known issues:
|
Commit 6900bbb needs global npm 10.5.0 and node 21.1.0 |
|
No description provided.