Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite BUILDKITE_METAHOOK_HOOKS_PATH, and shard vars by plugin configuration #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't overwrite BUILDKITE_METAHOOK_HOOKS_PATH, and shard vars by plugin configuration #12

wants to merge 2 commits into from

Commits on Jun 14, 2021

  1. Don't overwrite BUILDKITE_METAHOOK_HOOKS_PATH 

    If we have multiple `metahook` instances, let's not generate multiple
temporary directories; instead just create one (and only dump the
environment variables once).

This fixed an issue with multiple `metahook` instances in a pipeline of
mine.
    @staticfloat
    staticfloat committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d3dc683 View commit details
    Browse the repository at this point in the history

  2. Shard vars file between multiple plugin configurations 

    By hashing the `BUILDKITE_PLUGIN_CONFIGURATION` envvar, we can
effectively disambiguate multiple instances of the `metahook` plugin
within a single pipeline.  This allows us to seprate the `vars` file, as
it otherwise can get confused if you have multiple invocations of the
plugin that each use different hooks.
    @staticfloat
    staticfloat committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    96495eb View commit details
    Browse the repository at this point in the history