Format ingestion options #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #261
- [x] Set footer element during the construction of IA document
- [x] Rename "Style" setting to "Appearance"
- [x] Consolidate appearance settings logic into one function
Add an option to set a footer
- [x] Makes easier to enable likes + comments without any coding Relates to facebookarchive/facebook-instant-articles-sdk-php#195 Fixes imtepi#36 and #340
Switch on/off configuration for enabling comments/likes by default
Apester plugin support
Extracted anonymous inline function
- as @yssk22 commented in Automattic#428, the refactored code has been reverted back by mistake, and it result in garbled MB characters in title.
fix merge damage
[x] Depends on PR: facebookarchive/facebook-instant-articles-sdk-php#199 [x] Creates a new checkbox configuration to allow user to activate/deactivate formatting [x] Uses the configuration to apply the formatting style chosen on setup Depends on facebookarchive/facebook-instant-articles-sdk-php#199 Fixes #625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Follows #
Relates to #
Fixes #