add initializeCheckConfirmationAction to avoid "Required argument "ma… #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, that this is not a proper solution, although we already have it in our code. Why? The the methods return a "FowardResponse" with status 204. This leaves the browser on the current page and does not forward and display the form action on the same page. See also https://forge.typo3.org/issues/105034 and https://github.com/in2code-de/powermail/tree/bugfix/989_prevent-exception-in-create-action I am currently on that issue and will fix this too. |
…il" is not set for In2code\Powermail\Controller\FormController->checkConfirmation"
|
Needed to revert it, because several acceptance tests broke :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add initializeCheckConfirmationAction to avoid "Required argument "mail" is not set for In2code\Powermail\Controller\FormController->checkConfirmation"
This prevents the TYPO3 log from becoming cluttered.