Conversation
Clears the server’s 60-second write deadline. Immediately sends and flushes retry: 3000. Sends heartbeat comments every 15 seconds. Uses tenant.IsOkapiRequest to omit the wildcard CORS header on /broker/...; direct access retains it. Safely handles closed channels and repeated removal. Logs slow-client eviction and stream write failures.
jakub-id
requested review from
JanisSaldabols and
adamdickmeiss
as code owners
August 28, 2026 13:21
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SSE connection reliability improvements and grants relevant read roles access to the stream.
Changes:
- Adds heartbeats, retry hints, flushing, CORS handling, and failure logging.
- Makes client removal idempotent.
- Adds SSE lifecycle and CORS tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
broker/descriptors/ModuleDescriptor-template.json |
Grants SSE access to read permission sets. |
broker/api/sse_broker.go |
Improves SSE connection handling and observability. |
broker/api/sse_broker_test.go |
Tests stream setup, heartbeats, CORS, and removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…g, Okapi CORS handling, and safe client eviction/removal.
skomorokh
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.