Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for adding custom parameters to icecast.xml #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LucaTNT
Copy link

@LucaTNT LucaTNT commented Jan 2, 2021

I needed to set some custom mount options, so I added the ICECAST_EXTRA_PARAMETERS environment variable to allow users to specify custom xml to be added at the end of icecast.xml.

It works fine in my testing, but of course the user is free to enter invalid xml which would cause Icecast not to start. To be used with caution I guess 😃

@simonepozzoli
Copy link

In my opinion the best thing would be to directly mount a local icecast.xml file inside the container to override the settings. In this way you have full control over your settings and no other logic needs to be added to this repo.

@LucaTNT
Copy link
Author

LucaTNT commented May 23, 2022

That's right, but IMHO it's handy to have both the ease of setup that docker-entrypoint.sh provides, as well as the flexibility of adding a couple parameters as raw XML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants