Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: in-memory metadata client #268

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: in-memory metadata client #268

wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Sep 18, 2023 •
edited by bors bot
Loading

No description provided.

@morenol morenol force-pushed the lmm/memory-metadata-client branch 10 times, most recently from 879500c to aee7fdf Compare September 19, 2023 00:22
@morenol morenol requested a review from sehz September 19, 2023 00:30
@morenol
Copy link
Contributor Author

morenol commented Sep 19, 2023

.
one critical thing need is validate lock design. Can you try this https://amanieu.github.io/parking_lot/parking_lot/deadlock/index.html?.

@sehz it looks like that feature flag is only valid when we try to replace std::sync::Mutex with parking_lot::Mutex, I think that it is not valid for the async case

@morenol morenol changed the title feat: in-memory metadata client and move to anyhow feat: in-memory metadata client Sep 19, 2023
sehz
sehz approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's create issue for deadlock detection as tech debt.

@morenol
Copy link
Contributor Author

morenol commented Sep 19, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 19, 2023
@morenol
feat: in-memory metadata client (#268)
10e5882
@bors
Copy link

bors bot commented Sep 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: in-memory metadata client [Merged by Bors] - feat: in-memory metadata client Sep 19, 2023
@bors bors bot closed this Sep 19, 2023
@morenol morenol deleted the lmm/memory-metadata-client branch September 19, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morenol @sehz