-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README (add ref to tslink) #285
Conversation
Hello @sehz , would be nice to see your opinion about this PR and its subject |
you can try with example of combined usage
|
@morenol WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nice addition!
Hello, guys.
I have one suggestion for you and I'm doing it via PR ;)
Since I've been using node-bindgen for a long time already across a couple of projects I found missing TypeScript types a little annoying ).
That's just not comfortable from a testing and developing perspective.
You know, some small changes in data type on the native module side, and you shouldn't forget to update it on nodejs side too.
With TypeScript it is much easier. Imagine workflow:
You see? If some changes happen on step 1, on the heights level (nodejs) TypeScript compiler will inform about any errors. It makes a solution more stable and helps with testing indeed.
I've developed crate tslink which generates
*.d.ts
,*.js
and*.ts
files and actually creates a full-fledged npm package.As a bonus - code highlights on the IDE level as well.
What do you think about it?
If you are finding this useful for your users, let's add some remarks about it to your documentation.
P.S.
Combined usage
tslink
andnode-bindgen
is very much covered by tests, you can see it in repo of the project.