Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: update version #47

Closed
wants to merge 1 commit into from
Closed

Conversation

morenol
Copy link
Contributor

@morenol morenol commented May 29, 2023

No description provided.

@morenol morenol requested a review from EstebanBorai May 29, 2023 16:25
@EstebanBorai
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request May 29, 2023
@morenol
Copy link
Contributor Author

morenol commented May 29, 2023

I see that in this repo, we don't perform any cloud related test. So the tests that we currenyly have should be run as part of PR CIs, the issue is that we are calling fluvio cloud login before them and I think that it is not needed. I will create a PR removing that step to see if CI is green after that

@EstebanBorai
Copy link
Collaborator

I see that in this repo, we don't perform any cloud related test. So the tests that we currenyly have should be run as part of PR CIs, the issue is that we are calling fluvio cloud login before them and I think that it is not needed. I will create a PR removing that step to see if CI is green after that

SGTM! Im still have to setup integration tests here!

@EstebanBorai
Copy link
Collaborator

Tracking for Integration Tests: #9

@bors
Copy link

bors bot commented May 29, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: update version [Merged by Bors] - chore: update version May 29, 2023
@bors bors bot closed this May 29, 2023
@bors bors bot deleted the lmm/0_10_10 branch May 29, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants