Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: track ibc-rs PR 1158 #174

Merged
merged 6 commits into from
Apr 13, 2024
Merged

chore: track ibc-rs PR 1158 #174

merged 6 commits into from
Apr 13, 2024

Conversation

Farhad-Shabani
Copy link
Member

Cargo.lock Outdated
@@ -1034,8 +1034,7 @@ dependencies = [
[[package]]
name = "ibc"
version = "0.51.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8af2325614ae3274b2e70834bea56c1fa2758d802d364d89992b0fe820847fca"
source = "git+https://github.com/cosmos/ibc-rs.git#f7a3c2b23f42977392b2f2ca908cc98d00765ff5"
Copy link
Member

@rnbguy rnbguy Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like, the rev was set to wrong rev (it's the latest commit on main) 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I switch a lot between main and feat/sov-support, that's probably why!

Cargo.toml Outdated
Comment on lines 50 to 51
ibc = { git = "https://github.com/cosmos/ibc-rs.git", revision = "b2d426f" }
ibc-query = { git = "https://github.com/cosmos/ibc-rs.git", revision = "b2d426f" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revision was supposed to be rev. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no 😄

Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@Farhad-Shabani Farhad-Shabani merged commit 5b4d3a2 into main Apr 13, 2024
10 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/track-ibc-rs-1158 branch April 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants