feat(geo): manage layers and groups #1697
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
force-pushed
the
feature/layer-group-from-msp
branch
from
fc83bfa
to
b774742
Compare
|
Je l'ai identifié comme DRAFT parce qu'on est en mode test de notre côté. Ça serait bien que tu jette un oeil en code review tout de même voir si la structure/design vous convient. |
alecarn
force-pushed
the
feature/layer-group-from-msp
branch
from
5c8b79d
to
9945103
Compare
Breaking changes: This is a major refactor of the way we manage layer in IGO - New class 'LayerController' to manage layers and offer 3 types of layers, 'systemLayers', 'baseLayers', 'treeLayers'. The systemLayers is the drawing layer, measurement layer and other vital layers for the library. Note that a systemLayer can also be found in the treeLayers. The treeLayers is the hierarchical representation for the LayerViewer. The list of treeLayers can also be accessed under the flattened variant. Finally these three types of layers are aggregated to provide a unified list names 'all' which allows to have the 'baseLayers', 'systemLayers' and the flattened list of the 'treeLayers' - The way we access the layers has also changed, we must go through the LayerController - The LayerViewer does not allow to display the baseLayer, the 'excludeBaselayers' is removed (cherry picked from commit 5ed250d6ca2b27d904de8d3354c11a981c64bf67) fix: lint fix(geo): remove duplicate layer from all (cherry picked from commit 42e4fa9b739c555f3c0f5b3a098ab14307aaae67) fix(build): circular dependency revert compilationMode to full fix(geo): circular dependencies - refactor Layer/LayerGroup fix(geo): time-filter-list remove BaseLayer fix(geo): layer - project custom action in the bottom panel refactor: change label for group fix(geo): move layer with linkedLayers add system layer in tree fix: any chore: update packages chore: update packages fix: test chore: fix path for build
alecarn
force-pushed
the
feature/layer-group-from-msp
branch
from
9945103
to
a765ddb
Compare
- fix(geo): find by source id - fix(geo): raise/lower layer
- fix(geo): save expandable
- fix(geo): unhandled layer is added in the system layers
- fix: circular dependencies
The LayerController doest not reset all layers, the systemLayer are ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes: This is a major refactor of the way we manage layer in IGO
New class 'LayerController' to manage layers and offer 3 types of layers, 'systemLayers', 'baseLayers', 'treeLayers'. The systemLayers is the drawing layer, measurement layer and other vital layers for the library. Note that a systemLayer can also be found in the treeLayers. The treeLayers is the hierarchical representation for the LayerViewer. The list of treeLayers can also be accessed under the flattened variant. Finally these three types of layers are aggregated to provide a unified list names 'all' which allows to have the 'baseLayers', 'systemLayers' and the flattened list of the 'treeLayers'
The way we access the layers has also changed, we must go through the LayerController
The LayerViewer does not allow to display the baseLayer, the 'excludeBaselayers' is removed
(cherry picked from commit 5ed250d6ca2b27d904de8d3354c11a981c64bf67)