Fix ipv6 handling #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't done any testing on this after changes |
|
Hello Guys, Can someone provide any insights whether the modification was wrong or is this not the correct repo or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Description
This PR addresses the issue of improperly formatted IPv6 addresses in the connection strings. The existing configuration did not handle IPv6 addresses correctly, which leads to connection failures.
Changes Made
IPv6 Handling:
processConnectionStringfunction to check and enclose IPv6 addresses in[]brackets if necessary.amqp://user:pass@host:port) and without credentials (amqp://host:port).Configuration Updates:
processConnectionStringfunction before parsing the connection strings.Please review the changes and provide feedback.