Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string_ parser: check equality char by char to avoid unecessary IO #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sidkshatriya
Copy link

string_ parser: check equality char by char to avoid unecessary IO

We can bail out early if the prefix does not match

Addresses the code comment

 (* XXX(seliopou): Inefficient. Could check prefix equality to short-circuit
-   * the io. *)

We can bail out early if the prefix does not match
@sidkshatriya
Copy link
Author

cc: @seliopou

@sidkshatriya
Copy link
Author

sidkshatriya commented Mar 21, 2023

@seliopou -- gentle ping. I am eager to get this PR merged -- please let me know if I can get someone to review this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant