Fix: Harden CI/CD supply chain, formatting gates, and secret boundaries - #653
Open
mertcano wants to merge 1 commit into
Open
Fix: Harden CI/CD supply chain, formatting gates, and secret boundaries#653mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
### Description This PR addresses supply-chain security risks, implicit secret boundaries, and false-green CI checks identified during the workspace-wide security audit[cite: 53]. ### Key Changes * **Supply-Chain Security (Immutable Action References):** Replaced mutable action version tags (e.g., `v2`, `main`) with verified, full 40-character commit SHAs across `.github/workflows/cicd.yaml`[cite: 58], `.github/workflows/securesdlc.yml`[cite: 59], and `.github/actions/base-setup/action.yaml`[cite: 60]. This strictly prevents unreviewed upstream action changes from entering the deployment pipeline[cite: 53]. * **Formatting Gate (False-Green Prevention):** The formatting job in `cicd.yaml` previously mutated files during checkout (e.g., `prettier --write`), which could hide formatting drift and silently pass the CI check[cite: 53]. It now runs `pnpm run format:js:check`, acting as a strict, read-only validation gate[cite: 53, 58]. * **Explicit Secret Boundaries:** Prevented overly broad secret exposure by explicitly declaring and passing only the necessary secrets (`SEMGREP_APP_URL`, `SEMGREP_APP_TOKEN`, `SDLC_SLACK_NOTIFICATIONS`) to the nested SecureSDLC workflow in `cicd.yaml` and `securesdlc.yml`[cite: 53, 58, 59].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses supply-chain security risks, implicit secret boundaries, and false-green CI checks identified during the workspace-wide security audit[cite: 53].
Key Changes
v2,main) with verified, full 40-character commit SHAs across.github/workflows/cicd.yaml[cite: 58],.github/workflows/securesdlc.yml[cite: 59], and.github/actions/base-setup/action.yaml[cite: 60]. This strictly prevents unreviewed upstream action changes from entering the deployment pipeline[cite: 53].cicd.yamlpreviously mutated files during checkout (e.g.,prettier --write), which could hide formatting drift and silently pass the CI check[cite: 53]. It now runspnpm run format:js:check, acting as a strict, read-only validation gate[cite: 53, 58].SEMGREP_APP_URL,SEMGREP_APP_TOKEN,SDLC_SLACK_NOTIFICATIONS) to the nested SecureSDLC workflow incicd.yamlandsecuresdlc.yml[cite: 53, 58, 59].