Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): text field required onFieldSubmitted #1140

Merged
merged 6 commits into from
Nov 6, 2024
Merged

feat(cat-voices): text field required onFieldSubmitted #1140

merged 6 commits into from
Nov 6, 2024

Conversation

damian-molinski
Copy link
Contributor

Description

Making it required but nullable because default behaviour is to make some action when user taps enter. Focus next field or do smth else.

@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code labels Nov 5, 2024
@damian-molinski damian-molinski self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

dtscalac
dtscalac approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

✅ Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@dtscalac dtscalac merged commit 997e524 into main Nov 6, 2024
35 checks passed
@dtscalac dtscalac deleted the feat/text_field_required_submit branch November 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac approved these changes

@LynxLynxx LynxLynxx Awaiting requested review from LynxLynxx

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@damian-molinski damian-molinski

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.
2 participants
@damian-molinski @dtscalac