Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): recover different keychain #1147

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

damian-molinski
Copy link
Contributor

Description

This PR adds recover different keychain option to recovery flow

Related Issue(s)

Resolves #1092

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@damian-molinski damian-molinski added review me PR is ready for review dart Pull requests that update Dart code labels Nov 6, 2024
@damian-molinski damian-molinski self-assigned this Nov 6, 2024
@damian-molinski damian-molinski removed the request for review from minikin November 6, 2024 10:05
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit ea17789 into main Nov 6, 2024
35 checks passed
@dtscalac dtscalac deleted the feat/restore_different_keychain_1092 branch November 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : MVE2 refinement: restore a different account
2 participants