Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: C509 lib CLI example #625

Merged
merged 26 commits into from
Jul 26, 2024
Merged

feat: C509 lib CLI example #625

merged 26 commits into from
Jul 26, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jul 17, 2024

Description

Implement C509 lib CLI and example

Related Issue(s)

Closes #616

Description of Changes

CLI

  • generate command where it generate C509 certificate where it take a JSON file that contains necessary information to create the certificate. If the private key is provided, the certificate is signed.
  • verify command where it verify the C509 signature
  • decode command where it decode a C509 back to editable and readable file, in this case, JSON format is chosen. If the output is not given, the JSON will only be print out.
  • Provide a sample JSON file use to generate C509

Other

  • Add PEM file handling in signing.rs
  • Add additional necessary functions.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Test Report | ${\color{lightgreen}Pass: 102/102}$ | ${\color{red}Fail: 0/102}$ |

@bkioshn bkioshn self-assigned this Jul 18, 2024
@bkioshn bkioshn added the enhancement New feature or request label Jul 18, 2024
@bkioshn bkioshn added the review me PR is ready for review label Jul 18, 2024
@bkioshn bkioshn requested a review from Mr-Leshiy July 23, 2024 14:02
@bkioshn bkioshn requested a review from apskhem July 26, 2024 02:33
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 30b7bc7 into main Jul 26, 2024
35 checks passed
@minikin minikin deleted the feat/c509_cli branch July 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Create a cli for C509 library
4 participants