-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy playground manifests from repo #36
Conversation
deploy/marlowe-playground.yaml
Outdated
secretKeyRef: | ||
key: callbackPath | ||
name: gh-oauth-production | ||
image: ghcr.io/input-output-hk/marlowe-playground-server:2023-05-30-e2d5fd6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it is because it is production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I was told there would be a production image, but thats not there yet so I just hardcoded it at the version Jamie deployed to production. Once the production image is available someone should change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I imagine the thing would be to test it in practice, it is hard to know whether it will work otherwise
Temporarily disable new server image push for testing
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
7e75957
to
4b52b47
Compare
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
The application is being synced here https://vela.scdev.aws.iohkdev.io/applications/marlowe-playground-repo/config. The status of all components can also be viewed when clicking on marlowe-staging at the top.
Some remaining TODOs that I don't believe are blockers:
The override policy method is kind of pointless here because the production and staging manifests have to be separate files anyway.Using the topology policy and two workflow steps they can now be in the same filePre-submit checklist: