Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy playground manifests from repo #36

Merged
merged 62 commits into from
Oct 3, 2023
Merged

Deploy playground manifests from repo #36

merged 62 commits into from
Oct 3, 2023

Conversation

Pacman99
Copy link
Contributor

@Pacman99 Pacman99 commented Jun 2, 2023

The application is being synced here https://vela.scdev.aws.iohkdev.io/applications/marlowe-playground-repo/config. The status of all components can also be viewed when clicking on marlowe-staging at the top.

Some remaining TODOs that I don't believe are blockers:

  • production and staging files have some duplication (not a whole lot since most env vars end up having different references anyways). The override policy method is kind of pointless here because the production and staging manifests have to be separate files anyway. Using the topology policy and two workflow steps they can now be in the same file
  • When a new image is pushed because of a code change, I'm not sure if flux will realize and re-deploy, because I think only manifest changes cause re-deploy. The optimal solution to this is to have flux/kubevela build images as part of the deploy workflow, but a temporary solution is to trigger the deploy manually after images are pushed.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

secretKeyRef:
key: callbackPath
name: gh-oauth-production
image: ghcr.io/input-output-hk/marlowe-playground-server:2023-05-30-e2d5fd6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be hardcoded?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it is because it is production?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was told there would be a production image, but thats not there yet so I just hardcoded it at the version Jamie deployed to production. Once the production image is available someone should change it.

Copy link
Collaborator

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I imagine the thing would be to test it in practice, it is hard to know whether it will work otherwise

Pacman99 and others added 23 commits August 3, 2023 08:46
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@shlevy shlevy force-pushed the kube-deploy branch 2 times, most recently from 7e75957 to 4b52b47 Compare October 3, 2023 09:32
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@shlevy shlevy merged commit 7b884e3 into main Oct 3, 2023
2 of 3 checks passed
@shlevy shlevy deleted the kube-deploy branch October 3, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants