Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate IOGX #44

Merged
merged 26 commits into from
Aug 30, 2023
Merged

Integrate IOGX #44

merged 26 commits into from
Aug 30, 2023

Conversation

zeme-wana
Copy link
Contributor

@zeme-wana zeme-wana commented Aug 22, 2023

As part of the ongoing effort to build a Developer Platform for IOG, the smart-contracts-dev-empowerment team is releasing IOGX - a Flake Template for Haskell Projects at IOG

The vision of IOGX is to provide a JSON-like, declarative interface to Nix, so that developers unfamiliar with the language may independently maintain and add to the Nix sources with minimum effort.

The goal is to integrate with all Smart Contracts repositories, and maybe more.
There are currently 8 repositories using this, including marlowe-cardano.

As developers nothing changes for you: you will enter nix develop and you will get into a new shell.

There might be some rough edges but we will be prompt to smooth them.


Notable changes that might require review:

  • playwright has been disabled on Darwin so that Mac users may at least enter the shell

@zeme-wana zeme-wana marked this pull request as ready for review August 23, 2023 17:46
Copy link
Collaborator

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried local development and I was able to setup the backend and fronted without too much problem.

The only change that I ask is to update this documentation as we are switching from plain std to iogx

Also, I defer to @shlevy to check the ci/deployment part

.github/workflows/deploy.yml Show resolved Hide resolved
flake.nix Show resolved Hide resolved
marlowe-playground-client/spago-packages.nix Outdated Show resolved Hide resolved

{
modules = [{
packages.marlowe-symbolic.ghcOptions = [ "-Werror" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have these here instead of in cabal.project? @hrajchert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is common to all repos. Basically we want -Werror in CI, but not locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Might be nice to have some way to do this behind the scenes. E.g. ask haskell.nix "which packages in this package set were actually defined as top-level in the cabal.project?" and turn on Werror for all of those.

@zeme-wana zeme-wana added the No Changelog Required Turns of the check-changelog check label Aug 29, 2023
Copy link
Collaborator

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrajchert hrajchert merged commit 72e0eb1 into main Aug 30, 2023
5 checks passed
@hrajchert hrajchert deleted the iogx-v3-new branch August 30, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Turns of the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants