-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ApplicableInputs type #178
Conversation
WalkthroughThe update in the codebase involves the enhancement of module exports in a TypeScript file. It specifically adds the export of a new item, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/language/core/v1/src/next/index.ts (1 hunks)
Additional comments: 2
packages/language/core/v1/src/next/index.ts (2)
- 11-11: Export of
ApplicableInputs
is correct and aligns with the PR objectives.- 11-13: The
Next
type is now being exported as a constant, which changes its usage. Ensure that all references toNext
throughout the codebase are updated to reflect this change.
export { ApplicableInputs }; | ||
export type Next = t.TypeOf<typeof Next>; | ||
export const Next = t.type({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing Next
from a type to a runtime validator using t.type
alters its behavior significantly. This change implies that Next
can now be used for runtime type checking and validation, which was not possible when it was only a type alias. Confirm that this new behavior is intentional and that all uses of Next
are compatible with this change.
Summary by CodeRabbit