Add a DECTRIS SIMPLON API camera interface - #168
Open
Baharis wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I received a request to implement a DECTRIS SIMPLON API in Instamatic for a future user interested in using Instamatic with a JEOL + DECTRIS setup. I contacted another group who already got a similar setup working, but unfortunately due to unexpected circumstances I could not base my implementation on theirs. Consequently, I sat down today with the SIMPLON 1.8 API documentation and wrote the interface to the best of my abilities.
I called the new interface
simplonafter the API it communicates with. It is designed to work with any camera that uses this API, including DECTRIS QUADRO and SINGLA. It usesrequestslibrary, which has already been an implicit dependency of Instamatic via packagevirtualbox. Otherwise, the implementation it is similar to that of ASI-dedicatedserval.I already tested connection and some functionality against ansto-simplon-api. However, for simplicity, I decided to read images from the slower
monitorrather than a file stream, and said module is not implemented in their (otherwise great) tool. Consequently, I will test the new code on the live detector next week and merge the code after it is confirmed to work.Code additions
camera_simplon.py: Implementation for DECTRIS detectors via the SIMPLON API;simplon.yaml: Configuration file with default values set for DECTRIS QUADRO;camera.py: Added 'simplon' as one of available camera options;pyproject.toml,requirements.txt: Added explicitrequests >= 2.0.0dependency;readme.md: Added support for "DECTRIS cameras through SIMPLON API".