Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Init arch Xe2 #298

Open
wants to merge 34 commits into
base: xetla
Choose a base branch
from
Open

Init arch Xe2 #298

wants to merge 34 commits into from

Conversation

airMeng
Copy link
Contributor

@airMeng airMeng commented Jun 20, 2024

Type of Change

feature or bug fix or documentation or others
API changed or not

Description

detail description
Issues: xxx

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed

@sunjiweiswift sunjiweiswift force-pushed the xetla_int4_matB_col_major branch 2 times, most recently from 631b2a3 to 3d71451 Compare June 26, 2024 04:45
Base automatically changed from xetla_int4_matB_col_major to xetla June 27, 2024 12:42
@DDEle DDEle added the XeTLA label Jul 8, 2024
Copy link
Contributor

@DDEle DDEle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the config numbers of Xe2 and XeHpc are identical, maybe we can just add an alias instead of a complete class. A new class of config will add an additional of roughly 1/3 of the compilation/linkage workload while an alias is free.

BTW, what's the status of this PR?

Comment on lines -34 to -36
template <>
struct load_store_attr_t<msg_type::block_2d, gpu_arch::XeHpc> {
/// HW limitation checks https://gfxspecs.intel.com/Predator/Home/Index/55490
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple places with the gfxspecs link. I think they are helpful for internal developers. If they violate any company policies, they should be removed all at once in a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants