Parser: fix reading it->extra on big endian when bytesNeeded == 1

Signed-off-by: Dmitry Shachnev <mitya57@gmail.com>
intel · Sep 3, 2021 · d393c16 · d393c16
1 parent 8adc3cf
commit d393c16
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/cborparser.c b/src/cborparser.c
@@ -203,10 +203,13 @@ static CborError preparse_value(CborValue *it)
         it->extra = 0;
 
         /* read up to 16 bits into it->extra */
-        if (bytesNeeded <= 2) {
+        if (bytesNeeded == 1) {
+            uint8_t extra;
+            read_bytes_unchecked(it, &extra, 1, bytesNeeded);
+            it->extra = extra;
+        } else if (bytesNeeded == 2) {
             read_bytes_unchecked(it, &it->extra, 1, bytesNeeded);
-            if (bytesNeeded == 2)
-                it->extra = cbor_ntohs(it->extra);
+            it->extra = cbor_ntohs(it->extra);
         } else {
             cbor_static_assert(CborIteratorFlag_IntegerValueTooLarge == (Value32Bit & 3));
             cbor_static_assert((CborIteratorFlag_IntegerValueIs64Bit |