feat(incoming-payment): error log

interledger · Aug 14, 2024 · f39d329 · f39d329
1 parent ea46b1e
commit f39d329
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/backend/src/open_payments/payment/incoming/service.test.ts b/packages/backend/src/open_payments/payment/incoming/service.test.ts
@@ -190,6 +190,7 @@ describe('Incoming Payment Service', (): void => {
         expect(approvedIncomingPayment.approvedAt).toBeDefined()
         expect(!approvedIncomingPayment.cancelledAt).toBeTruthy()
         expect(approvedIncomingPayment.cancelledAt).toBeFalsy()
+      })
     })
 
     describe('cancelIncomingPayment', (): void => {

diff --git a/packages/backend/src/open_payments/payment/incoming/service.ts b/packages/backend/src/open_payments/payment/incoming/service.ts
@@ -154,9 +154,22 @@ async function createIncomingPayment(
       timeoutMs: deps.config.incomingPaymentCreatedPollTimeout
     })
 
-    if (response) return response
+    if (response?.cancelledAt) {
+      deps.logger.error(
+        { cancelledAt: response.cancelledAt.toISOString() },
+        'Incoming payment was cancelled'
+      )
+      return IncomingPaymentError.ActionNotPerformed
+    }
+
+    if (response?.approvedAt) return response
     return IncomingPaymentError.ActionNotPerformed
   } catch (err) {
+    const errorMessage = 'Got error / timeout while polling incoming payment'
+    deps.logger.error(
+      { errorMessage: err instanceof Error && err.message },
+      errorMessage
+    )
     return IncomingPaymentError.ActionNotPerformed
   }
 }