Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry stack to local playground #2804

Merged
merged 11 commits into from
Jul 15, 2024
Merged

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Jul 10, 2024

Changes proposed in this pull request

This PR adds configuration for running a telemetry stack (OpenTelemetry collector, Prometheus and Grafana) as part of our local playground. This the first part of performance testing Rafiki: soon, we will be able to run load/stress tests in the local playground, and be able to see the metrics data from our tests.

It also includes an example dashboard in Grafana to view our transaction amount and transaction count metrics:

Screenshot 2024-07-12 at 18 13 02

Context

Fixes #2800

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 56bd60b
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/669549ff3113b400087a5502
😎 Deploy Preview https://deploy-preview-2804--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mkurapov mkurapov marked this pull request as ready for review July 12, 2024 16:19
@mkurapov mkurapov changed the title feat: add telemetry stack to localenv under command feat: add telemetry stack to local playground Jul 12, 2024
Comment on lines +23 to +24
"localenv:compose:psql:telemetry": "docker compose -f ./localenv/cloud-nine-wallet/docker-compose.yml -f ./localenv/happy-life-bank/docker-compose.yml -f ./localenv/merged/docker-compose.yml -f ./localenv/telemetry/docker-compose.yml",
"localenv:compose:telemetry": "docker compose -f ./localenv/cloud-nine-wallet/docker-compose.yml -f ./localenv/happy-life-bank/docker-compose.yml -f ./localenv/merged/docker-compose.yml -f ./localenv/tigerbeetle/docker-compose.yml -f ./localenv/telemetry/docker-compose.yml --env-file ./localenv/tigerbeetle/.env.tigerbeetle",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beyond scope of this task, but yet another variation of localenv:compose definitely suggests we should make a start script that handles these options as discussed in slack. would be nice to be able to mix and match as needed without a bespoke command

BlairCurrey
BlairCurrey previously approved these changes Jul 12, 2024
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it works for me. thanks for doing this - big help for testing stuff out.

koekiebox
koekiebox previously approved these changes Jul 15, 2024
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@mkurapov mkurapov dismissed stale reviews from koekiebox and BlairCurrey via 56bd60b July 15, 2024 16:10
@mkurapov mkurapov merged commit 771d189 into main Jul 15, 2024
33 of 42 checks passed
@mkurapov mkurapov deleted the 2800/mk/local-telemetry branch July 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telemetry services to rafiki local playground
3 participants