Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): add rate probe metric #2820

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat(backend): add rate probe metric #2820

merged 1 commit into from
Jul 29, 2024

Conversation

BlairCurrey
Copy link
Contributor

@BlairCurrey BlairCurrey commented Jul 23, 2024 •
edited
Loading

Changes proposed in this pull request

  • adds ilp_rate_probe_time_ms histogram metric and visualization to the local grafana example dashboard

Context

fixes: #2801

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Jul 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 4ebf5a5
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/669fd4a6313a3300082cb23c

@BlairCurrey BlairCurrey marked this pull request as ready for review July 23, 2024 19:30
koekiebox
koekiebox approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BlairCurrey BlairCurrey merged commit 3fd34dd into main Jul 29, 2024
36 of 42 checks passed
@BlairCurrey BlairCurrey deleted the bc/2801/rate-probe-metric branch July 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koekiebox koekiebox koekiebox approved these changes

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ILP rate probe histogram metric
3 participants
@BlairCurrey @koekiebox @mkurapov