Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): ux improvements to liquidity dialog component #2839

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

Emanuel-Palestino
Copy link
Contributor

Changes proposed in this pull request

  • Make the LiquidityDialog component retains underlying page scroll position on asset page.
  • Add autofocus to the input of LiquidityDialog in order to improve the user experience.

This pull request resolves the #2825 issue.

@github-actions github-actions bot added the pkg: frontend Changes in the frontend package. label Aug 3, 2024
Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 9f470fc
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66ae688417cc9e000883f7f0

@BlairCurrey BlairCurrey self-requested a review August 5, 2024 13:59
Copy link
Contributor

@BlairCurrey BlairCurrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Emanuel-Palestino, thanks!

@BlairCurrey BlairCurrey merged commit b0d282b into interledger:main Aug 5, 2024
36 of 42 checks passed
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
* fixed(frontend) asset page now retains page scroll position.

* feat(frontend) added autofocus to liquidity dialog input

* feat(fronted) made eslint happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: frontend Changes in the frontend package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants