Fix list grid view alignment - #13385
Open
CipherZ3r0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13352
FIX : This fixes the alignment of the Preview action in the list/grid view when a book does not have a preview available.
Technical
openlibrary/macros/BookPreview.htmlto handle books without anocaid.ocaidwas present, which caused the CTA area to be missing and resulted in inconsistent alignment.No Previewstate when noocaidis available.<span>rather than a link.Testing
TestHomeTemplates.test_home_templatedue to the missingQueryCarouselmacro in the test environment.Screenshot
Stakeholders
@RayBB