Acquisitions in search.json — weave provider acquisitions at query time (#12844) - #13395
Draft
openlibrary-bot wants to merge 1 commit into
Draft
Acquisitions in search.json — weave provider acquisitions at query time (#12844)#13395openlibrary-bot wants to merge 1 commit into
openlibrary-bot wants to merge 1 commit into
Conversation
… v1) Acquisition.get_by_editions batch-fetches acquisitions by edition_id; add_acquisitions() attaches them to search-result docs (edition-scoped, no N+1). Wired into _process_solr_search_response, gated on 'acquisitions' being among the requested fields -- mirrors the availability weave, query-time fetch (not embedded in Solr).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the ingestion PR #13241. Purely additive, read-side change: weaves provider acquisitions from the
acquisitionstable onto edition docs insearch.jsonat query time (mirrors availability weaving), gated behind theacquisitionsfield. Carved out of #13241 so ingestion can land independently — this surfaces the value once data is flowing. Depends only on the acquisitions table (#12851, already on master); it will show results once #13241's ingestion is populating rows. Note: relies onsolr_editions(editions expanded in the response). Part of #12844.