Remove unused lending/borrow/waitinglist methods - #13396
Open
cdrini wants to merge 7 commits into
Open
Conversation
cdrini
force-pushed
the
remove-unused-update-loan-status
branch
from
August 21, 2026 15:13
cc05455 to
ae80470
Compare
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
… helpers Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
…ilder Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Co-Authored-By: Drini Cami <cdrini@gmail.com>
cdrini
force-pushed
the
remove-unused-update-loan-status
branch
from
August 21, 2026 19:52
8a5533c to
37d84fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to asyncify some of this code, it's exceedingly tricky because of how many similarly named but slightly different methods exist in this space. A lot of this duplication is because we used to store loans in the open library database many years ago, in site.store with type=/type/loans . I checked the prod db and there are 581 rows there from 2014 . So that's a dead code path now, and resulted in some code being deleted. Otherwise it was a lot of removing unused methods or dissolving some single-use methods.
Technical
Testing
Screenshot
Stakeholders