Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec 3.11.0+ distinguish between hashes and Ruby 3 keywords #205

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Sep 6, 2022

This is due to change in RSpec [1], which cuases issues such as:

  1) MultiJson default options sets both load and dump options
     Failure/Error: self.load_options = self.dump_options = value

       MultiJson received :dump_options= with unexpected arguments
         expected: ({:foo=>"bar"})
              got: ({:foo=>"bar"})
     # ./lib/multi_json.rb:15:in `default_options='
     # ./spec/multi_json_spec.rb:171:in `block (4 levels) in <top (required)>'
     # /builddir/build/BUILD/spec/spec_helper.rb:12:in `silence_warnings'
     # ./spec/multi_json_spec.rb:171:in `block (3 levels) in <top (required)>'

Fixes #203

@voxik voxik changed the title RSpec 3.11.0+ distinguishes between hashed and Ruby 3 keywords RSpec 3.11.0+ distinguishes between hashes and Ruby 3 keywords Sep 6, 2022
@voxik voxik changed the title RSpec 3.11.0+ distinguishes between hashes and Ruby 3 keywords RSpec 3.11.0+ distinguish between hashes and Ruby 3 keywords Sep 6, 2022
This is due to change in RSpec [[1]], which cuases issues such as:

~~~
  1) MultiJson default options sets both load and dump options
     Failure/Error: self.load_options = self.dump_options = value

       MultiJson received :dump_options= with unexpected arguments
         expected: ({:foo=>"bar"})
              got: ({:foo=>"bar"})
     # ./lib/multi_json.rb:15:in `default_options='
     # ./spec/multi_json_spec.rb:171:in `block (4 levels) in <top (required)>'
     # /builddir/build/BUILD/spec/spec_helper.rb:12:in `silence_warnings'
     # ./spec/multi_json_spec.rb:171:in `block (3 levels) in <top (required)>'
~~~

Fixes intridea#203

[1]: rspec/rspec-mocks#1394
@djberg96
Copy link
Contributor

@mbleigh @joshk @sferik or @rwz are y'all still maintaining this gem? Any chance we could incorporate these changes, as well as #202?

@sferik sferik merged commit 98c99d2 into intridea:master Mar 11, 2024
@voxik voxik deleted the rspec-kwargs branch March 11, 2024 21:33
@sferik
Copy link
Member

sferik commented Mar 12, 2024

Thanks for the ping. I just merged this and #202. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with RSpec 3.10.2 +
3 participants