ui: render access request form based on settings #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
approved these changes
Jul 24, 2023
| {%- if accept_conditions_text %} | ||
| <p> | ||
| <h5>{{ _("You need to satisfy these conditions in order for this request to be accepted:") }}</h5> | ||
| {{ _(accept_conditions_text) | safe }} |
There was a problem hiding this comment.
this is redundant I think because it will not mark the resolved text as translatable but rather the variable accept_conditions_text but maybe to be checked
There was a problem hiding this comment.
Saw the example here: https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/theme/templates/semantic-ui/invenio_app_rdm/header.html#L33
But you're right, seems like we can't translate everything that user can put into that field
anikachurilova
force-pushed
the
access-request-implement-settings
branch
from
ece8806
to
391cf53
Compare
zzacharo
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case 1:
accept_conditions_text = nullor absentCase 2:
accept_conditions_text = "Buy me a unicorn"Case 3:
accept_conditions_text = "<h1>Buy me a unicorn</h1>"Case 4:
allow_user_requestsorallow_guest_requestsis set to false: