Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: fix item description overflow issue #2875

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Oct 10, 2024

  • addresses mathjax formulas truncation

Forced overflow (formula simply is hidden):
Screenshot 2024-10-10 at 12 30 59

before forcing the overflow
Screenshot 2024-10-10 at 12 31 12

@@ -109,6 +110,13 @@
}

.content {
.description.truncate-lines-2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like not very well supported by browsers (yet)? Did you manage to test it with the mainstream browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked https://caniuse.com/css-line-clamp it does not seem to be aligned with mozilla docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-10 at 13 54 29

Copy link
Contributor Author

@kpsherva kpsherva Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked on safari, chrome, firefox, opera: works on all of them
mobile: chrome, firefox, DuckDuckGo, safari: works as well. Looks like the docs are not up to date

* addresses mathjax formulas truncation
@kpsherva kpsherva merged commit c97c828 into inveniosoftware:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To release 🤖
Development

Successfully merging this pull request may close these issues.

2 participants