Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subcommunities: updated page layout #1223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alejandromumo
Copy link
Member

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with an acceptable reverse "dependency" that we can sort out in the future.

<div class="ui container mb-0">
<div class="ui breadcrumb">
<a class="section"
href="{{ url_for('invenio_app_rdm_communities.communities_browse', pid_value=community.slug ) }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: I guess we're aware of the "backwards" reference to Invenio-App-RDM? In theory "Browse" as a concept only exists there.

Copy link
Member Author

@alejandromumo alejandromumo Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was discussed when we first implemented the browse page. Unfortunately, there's some entanglement that IMO should be cleaned up when we have more time.

Since this is just adding breadcrumbs though, one alternative would be to override this template in app-rdm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collections to browse page
2 participants