[to #763] Pick bug fixes of API v2 codec to master (#769) #1
iosmanthusAnnotations
18 errors and 77 warnings
|
Integration Test - v6.5.3
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
io.netty.internal.tcnative.AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
io.netty.internal.tcnative.AsyncSSLPrivateKeyMethod
|
|
Integration Test - v6.5.3
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255
|
|
Integration Test - v7.1.1
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v7.1.1
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v7.1.1
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - v7.1.1
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255
|
|
Integration Test - nightly
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
Integration Test - nightly
io/netty/internal/tcnative/AsyncSSLPrivateKeyMethod
|
|
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD:
src/main/java/org/tikv/common/MetricsServer.java#L75
Write to static field org.tikv.common.MetricsServer.METRICS_SERVER_INSTANCE from instance method org.tikv.common.MetricsServer.close()
|
|
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD:
src/main/java/org/tikv/common/MetricsServer.java#L79
Write to static field org.tikv.common.MetricsServer.metricsServerRefCount from instance method org.tikv.common.MetricsServer.close()
|
|
NP_BOOLEAN_RETURN_NULL:
src/main/java/org/tikv/common/PDClient.java#L235
org.tikv.common.PDClient.isCheckerPaused(PDChecker) has Boolean return type and returns explicit null
|
|
UPM_UNCALLED_PRIVATE_METHOD:
src/main/java/org/tikv/common/TiConfiguration.java#L398
Private method org.tikv.common.TiConfiguration.getBoolean(String, boolean) is never called
|
|
UPM_UNCALLED_PRIVATE_METHOD:
src/main/java/org/tikv/common/TiConfiguration.java#L381
Private method org.tikv.common.TiConfiguration.getDouble(String) is never called
|
|
UPM_UNCALLED_PRIVATE_METHOD:
src/main/java/org/tikv/common/TiConfiguration.java#L362
Private method org.tikv.common.TiConfiguration.getInt(String, int) is never called
|
|
SWL_SLEEP_WITH_LOCK_HELD:
src/main/java/org/tikv/common/TiSession.java#L750
org.tikv.common.TiSession.closeAwaitTermination(long) calls Thread.sleep() with a lock held
|
|
VA_FORMAT_STRING_USES_NEWLINE:
src/main/java/org/tikv/common/catalog/CatalogTransaction.java#L59
Format string should use %n rather than \n in org.tikv.common.catalog.CatalogTransaction.parseFromJson(ByteString, Class)
|
|
RR_NOT_CHECKED:
src/main/java/org/tikv/common/codec/CodecDataInput.java#L123
org.tikv.common.codec.CodecDataInput.readPartialUnsignedShort() ignores result of java.io.DataInputStream.read(byte[], int, int)
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/codec/MetaCodec.java#L86
Found reliance on default encoding in org.tikv.common.codec.MetaCodec.autoTableIDKey(long): String.getBytes()
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/codec/MetaCodec.java#L72
Found reliance on default encoding in org.tikv.common.codec.MetaCodec.decodeHashDataKey(ByteString): new String(byte[])
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/codec/MetaCodec.java#L94
Found reliance on default encoding in org.tikv.common.codec.MetaCodec.encodeDatabaseID(long): String.getBytes()
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/codec/MetaCodec.java#L90
Found reliance on default encoding in org.tikv.common.codec.MetaCodec.tableKey(long): String.getBytes()
|
|
MS_SHOULD_BE_FINAL:
src/main/java/org/tikv/common/codec/MetaCodec.java#L40
org.tikv.common.codec.MetaCodec.KEY_DBs isn't final but should be
|
|
MS_SHOULD_BE_FINAL:
src/main/java/org/tikv/common/codec/MetaCodec.java#L42
org.tikv.common.codec.MetaCodec.KEY_SCHEMA_VERSION isn't final but should be
|
|
MS_SHOULD_BE_FINAL:
src/main/java/org/tikv/common/codec/MetaCodec.java#L41
org.tikv.common.codec.MetaCodec.KEY_TABLE isn't final but should be
|
|
SR_NOT_CHECKED:
src/main/java/org/tikv/common/codec/MetaCodec.java#L75
org.tikv.common.codec.MetaCodec.decodeHashDataKey(ByteString) ignores result of org.tikv.common.codec.CodecDataInput.skipBytes(int)
|
|
SF_SWITCH_NO_DEFAULT:
src/main/java/org/tikv/common/codec/MyDecimal.java#L114
Switch statement found in org.tikv.common.codec.MyDecimal.readWord(int[], int, int) where default case is missing
|
|
SF_SWITCH_NO_DEFAULT:
src/main/java/org/tikv/common/codec/MyDecimal.java#L745
Switch statement found in org.tikv.common.codec.MyDecimal.writeWord(int[], int, int, int) where default case is missing
|
|
BIT_SIGNED_CHECK_HIGH_BIT:
src/main/java/org/tikv/common/codec/RowDecoderV2.java#L118
Check for sign of bitwise operation involving 0x8000000000000000 (-9223372036854775808) in org.tikv.common.codec.RowDecoderV2.decodeDouble(byte[])
|
|
BIT_IOR_OF_SIGNED_BYTE:
src/main/java/org/tikv/common/codec/RowEncoderV2.java#L298
Bitwise OR of signed byte value computed in org.tikv.common.codec.RowEncoderV2.encodeBit(CodecDataOutput, Object)
|
|
MS_SHOULD_BE_FINAL:
src/main/java/org/tikv/common/codec/RowV2.java#L25
org.tikv.common.codec.RowV2.CODEC_VER isn't final but should be
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/columnar/TiBlockColumnVector.java#L266
Found reliance on default encoding in org.tikv.common.columnar.TiBlockColumnVector.getUTF8String(int): new String(byte[])
|
|
DLS_DEAD_LOCAL_STORE:
src/main/java/org/tikv/common/columnar/TiChunkColumnVector.java#L213
Dead store to resultFrac in org.tikv.common.columnar.TiChunkColumnVector.getMyDecimal(int)
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/columnar/TiChunkColumnVector.java#L240
Found reliance on default encoding in org.tikv.common.columnar.TiChunkColumnVector.getEnumString(int): new String(byte[])
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/columnar/TiChunkColumnVector.java#L258
Found reliance on default encoding in org.tikv.common.columnar.TiChunkColumnVector.getUTF8String(int): new String(byte[])
|
|
ICAST_INTEGER_MULTIPLY_CAST_TO_LONG:
src/main/java/org/tikv/common/event/CacheInvalidateEvent.java#L67
Result of integer multiplication cast to long in org.tikv.common.event.CacheInvalidateEvent.hashCode()
|
|
SE_NO_SERIALVERSIONID:
src/main/java/org/tikv/common/expression/ComparisonBinaryExpression.java#L39
org.tikv.common.expression.ComparisonBinaryExpression is Serializable; consider declaring a serialVersionUID
|
|
SE_NO_SERIALVERSIONID:
src/main/java/org/tikv/common/expression/StringRegExpression.java#L38
org.tikv.common.expression.StringRegExpression is Serializable; consider declaring a serialVersionUID
|
|
EQ_DOESNT_OVERRIDE_EQUALS:
src/main/java/org/tikv/common/key/CompoundKey.java#L1
org.tikv.common.key.CompoundKey doesn't override Key.equals(Object)
|
|
EQ_DOESNT_OVERRIDE_EQUALS:
src/main/java/org/tikv/common/key/IndexKey.java#L1
org.tikv.common.key.IndexKey doesn't override Key.equals(Object)
|
|
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD:
src/main/java/org/tikv/common/key/IndexKey.java#L48
Unread public/protected field: org.tikv.common.key.IndexKey$EncodeIndexDataResult.appendHandle
|
|
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD:
src/main/java/org/tikv/common/key/IndexKey.java#L47
Unread public/protected field: org.tikv.common.key.IndexKey$EncodeIndexDataResult.keys
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/key/Key.java#L37
org.tikv.common.key.Key.TBL_PREFIX should be package protected
|
|
EQ_DOESNT_OVERRIDE_EQUALS:
src/main/java/org/tikv/common/key/RowKey.java#L1
org.tikv.common.key.RowKey doesn't override Key.equals(Object)
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/key/TypedKey.java#L100
Found reliance on default encoding in org.tikv.common.key.TypedKey.next(): String.getBytes()
|
|
EQ_DOESNT_OVERRIDE_EQUALS:
src/main/java/org/tikv/common/key/TypedKey.java#L1
org.tikv.common.key.TypedKey doesn't override Key.equals(Object)
|
|
WMI_WRONG_MAP_ITERATOR:
src/main/java/org/tikv/common/meta/Collation.java#L254
org.tikv.common.meta.Collation.<static initializer for Collation>() makes inefficient use of keySet iterator instead of entrySet iterator
|
|
REC_CATCH_EXCEPTION:
src/main/java/org/tikv/common/operation/iterator/ConcreteScanIterator.java#L99
Exception is caught when Exception is not thrown in org.tikv.common.operation.iterator.ConcreteScanIterator.resolveCurrentLock(Kvrpcpb$KvPair)
|
|
URF_UNREAD_FIELD:
src/main/java/org/tikv/common/policy/RetryPolicy.java#L33
Unread field: org.tikv.common.policy.RetryPolicy.backOffer
|
|
UC_USELESS_OBJECT:
src/main/java/org/tikv/common/predicates/ScanSpec.java#L112
Useless object stored in variable pointTypes of method org.tikv.common.predicates.ScanSpec$Builder.build()
|
|
NP_BOOLEAN_RETURN_NULL:
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java#L265
org.tikv.common.region.AbstractRegionStoreClient.seekLeaderStore(BackOffer) has Boolean return type and returns explicit null
|
|
SIC_INNER_SHOULD_BE_STATIC:
src/main/java/org/tikv/common/region/TiRegion.java#L287
Should org.tikv.common.region.TiRegion$RegionVerID be a _static_ inner class?
|
|
HE_EQUALS_USE_HASHCODE:
src/main/java/org/tikv/common/region/TiStore.java#L49
org.tikv.common.region.TiStore defines equals and uses Object.hashCode()
|
|
HE_EQUALS_USE_HASHCODE:
src/main/java/org/tikv/common/replica/Store.java#L117
org.tikv.common.replica.Store defines equals and uses Object.hashCode()
|
|
EQ_COMPARETO_USE_OBJECT_EQUALS:
src/main/java/org/tikv/common/statistics/Bucket.java#L60
org.tikv.common.statistics.Bucket defines compareTo(Bucket) and uses Object.equals()
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L35
org.tikv.common.types.BitType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L41
org.tikv.common.types.BytesType.subTypes should be package protected
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/types/Converter.java#L180
Found reliance on default encoding in org.tikv.common.types.Converter.convertToBytes(Object): String.getBytes()
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/types/Converter.java#L193
Found reliance on default encoding in org.tikv.common.types.Converter.convertToBytes(Object, int): String.getBytes()
|
|
DM_DEFAULT_ENCODING:
src/main/java/org/tikv/common/types/Converter.java#L203
Found reliance on default encoding in org.tikv.common.types.Converter.convertUtf8ToBytes(Object, int): new String(byte[])
|
|
MS_EXPOSE_REP:
src/main/java/org/tikv/common/types/Converter.java#L217
Public static org.tikv.common.types.Converter.getLocalTimezone() may expose internal representation by returning Converter.localTimeZone
|
|
REC_CATCH_EXCEPTION:
src/main/java/org/tikv/common/types/Converter.java#L358
Exception is caught when Exception is not thrown in org.tikv.common.types.Converter.convertStrToDuration(String)
|
|
SA_LOCAL_SELF_COMPUTATION:
src/main/java/org/tikv/common/types/Converter.java#L342
Nonsensical self computation of hour with itself in org.tikv.common.types.Converter.convertStrToDuration(String)
|
|
BIT_SIGNED_CHECK:
src/main/java/org/tikv/common/types/DataType.java#L541
Check for sign of bitwise operation in org.tikv.common.types.DataType.isNoDefault()
|
|
BIT_SIGNED_CHECK:
src/main/java/org/tikv/common/types/DataType.java#L585
Check for sign of bitwise operation in org.tikv.common.types.DataType.isNum()
|
|
BIT_SIGNED_CHECK:
src/main/java/org/tikv/common/types/DataType.java#L569
Check for sign of bitwise operation in org.tikv.common.types.DataType.isOnUpdateNow()
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L37
org.tikv.common.types.DateTimeType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L38
org.tikv.common.types.DateType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L39
org.tikv.common.types.DecimalType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L44
org.tikv.common.types.EnumType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L40
org.tikv.common.types.IntegerType.subTypes should be package protected
|
|
MS_FINAL_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L46
org.tikv.common.types.JsonType.subTypes should be both final and package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L42
org.tikv.common.types.RealType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L45
org.tikv.common.types.SetType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L36
org.tikv.common.types.StringType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L47
org.tikv.common.types.TimeType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L43
org.tikv.common.types.TimestampType.subTypes should be package protected
|
|
MS_PKGPROTECT:
src/main/java/org/tikv/common/types/DataTypeFactory.java#L48
org.tikv.common.types.UninitializedType.subTypes should be package protected
|
|
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE:
src/main/java/org/tikv/common/util/RangeSplitter.java#L173
Redundant nullcheck of regionStorePair, which is known to be non-null in org.tikv.common.util.RangeSplitter.splitRangeByRegion(List, TiStoreType)
|
|
UPM_UNCALLED_PRIVATE_METHOD:
src/main/java/org/tikv/raw/RawKVClient.java#L1090
Private method org.tikv.raw.RawKVClient.scan0(ScanOption) is never called
|
|
Integration Test - v6.5.3
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Integration Test - v6.5.3
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Integration Test - v7.1.1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Integration Test - v7.1.1
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Integration Test - nightly
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Integration Test - nightly
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-java@v2, codecov/codecov-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|