Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin torch version until deprecated functionality is fixed #147

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Sep 17, 2024

Recent torch 2.5 versions failing with ImportError: cannot import name 'dynamic_dim' from 'torch.export', pin torch version <2.5.0 for now, until proper fix is ready #145

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84 Hardcode84 changed the title pin torch Pin torch version until deprecated functionality is fixed Sep 17, 2024
@Hardcode84
Copy link
Contributor Author

seems to work

@Hardcode84 Hardcode84 marked this pull request as ready for review September 17, 2024 17:50
@harsh-nod
Copy link
Contributor

thanks! this will help keep the builders green till we figure out how to migrate to 2.6.

@stellaraccident
Copy link
Collaborator

Can you please note what the issue was?

I'm working on this for 2.6 support: #145

@Hardcode84
Copy link
Contributor Author

Hardcode84 commented Sep 17, 2024

This is because of missing dynamic_dim issue, see https://github.com/iree-org/iree-turbine/actions/runs/10876749148/job/30182209664 for example.

Also, pip reports it's still torch 2.5, not 2.6

@Hardcode84
Copy link
Contributor Author

let me try, actually

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
Copy link
Contributor Author

yep, <2.6 doesn't work

This reverts commit 7d7e5ff.

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@stellaraccident
Copy link
Collaborator

This is because of missing dynamic_dim issue, see https://github.com/iree-org/iree-turbine/actions/runs/10876749148/job/30182209664 for example.

Also, pip reports it's still torch 2.5, not 2.6

Update the PR description please and note that #145 is in progress to fix this.

@Hardcode84 Hardcode84 merged commit 7300a8d into iree-org:main Sep 17, 2024
7 of 8 checks passed
@Hardcode84 Hardcode84 deleted the pin-torch branch September 17, 2024 18:46
IanNod pushed a commit to IanNod/iree-turbine that referenced this pull request Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name
'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now,
until proper fix is ready
iree-org#145

---------

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
IanNod pushed a commit to IanNod/iree-turbine that referenced this pull request Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name
'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now,
until proper fix is ready
iree-org#145

---------

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
IanNod pushed a commit to IanNod/iree-turbine that referenced this pull request Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name
'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now,
until proper fix is ready
iree-org#145

---------

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants