Pin torch version until deprecated functionality is fixed #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcode84
changed the title
|
seems to work |
|
thanks! this will help keep the builders green till we figure out how to migrate to 2.6. |
harsh-nod
approved these changes
Sep 17, 2024
|
Can you please note what the issue was? I'm working on this for 2.6 support: #145 |
|
This is because of missing Also, pip reports it's still torch 2.5, not 2.6 |
|
let me try, actually |
|
yep, <2.6 doesn't work |
This reverts commit 7d7e5ff. Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Hardcode84
force-pushed
the
pin-torch
branch
from
b8f64d3
to
868c6a7
Compare
Update the PR description please and note that #145 is in progress to fix this. |
stellaraccident
approved these changes
Sep 17, 2024
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name 'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now, until proper fix is ready iree-org#145 --------- Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name 'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now, until proper fix is ready iree-org#145 --------- Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com> Signed-off-by: Ian <ian.nordeng@amd.com>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Recent torch 2.5 versions failing with `ImportError: cannot import name 'dynamic_dim' from 'torch.export'`, pin torch version `<2.5.0` for now, until proper fix is ready iree-org#145 --------- Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com> Signed-off-by: Ian <ian.nordeng@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent torch 2.5 versions failing with
ImportError: cannot import name 'dynamic_dim' from 'torch.export', pin torch version<2.5.0for now, until proper fix is ready #145