[TKW] Igemm opt #203
Draft
[TKW] Igemm opt #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-nod
reviewed
Oct 8, 2024
| @@ -757,14 +757,14 @@ def test_igemm_conv(n, h, w, c, hf, wf, nf, stride, mem_space, layout, request): | |||
| inputs={ | |||
| N: i // SZ_OUT, | |||
| C: j // (HF * WF), | |||
| H: (i % SZ_OUT) % W_OUT * stride + (j % (HF * WF)) % WF, | |||
| W: (i % SZ_OUT) // W_OUT * stride + (j % (HF * WF)) // WF, | |||
| W: (i % SZ_OUT) % W_OUT * stride + (j % (HF * WF)) % WF, | |||
There was a problem hiding this comment.
was this a bug? how were the tests passing if we had H and W switched?
There was a problem hiding this comment.
This changes how we unroll conv window (rows vs colums first), it should produce semantically equivalent result as long as it synchronized between all mapping. But it also affects memory access pattern and this way it's slightly faster.
harsh-nod
reviewed
Oct 8, 2024
tests/kernel/wave/wave_e2e_test.py
Outdated
| constraints += [tkw.WorkgroupConstraint(M, BLOCK_M, 1)] | ||
| constraints += [tkw.WorkgroupConstraint(NF, BLOCK_N, 0)] | ||
| constraints += [tkw.WaveConstraint(M, BLOCK_M / 2)] | ||
| constraints += [tkw.WaveConstraint(NF, BLOCK_N / 2)] |
There was a problem hiding this comment.
If you update the wave constraint, you also have to update the waves_per_block to be (2, 2, 1)
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
This reverts commit 4b8cd0c. Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.