Add support for batch matmuls #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-nod
force-pushed
the
batched
branch
8 times, most recently
from
a858a34
to
cb92697
Compare
harsh-nod
requested review from
Hardcode84,
erman-gurses,
martin-luecke and
raikonenfnu
Hardcode84
approved these changes
Oct 15, 2024
This PR adds support for batch dimensions. They can be specified in the vector_shapes dict with a shape of 0 with a corresponding workgroup constraint. This specifies that we want to distribute the batch dim among workgroups, but not among threads. Signed-off-by: Harsh Menon <harsh@nod-labs.com>
Signed-off-by: Harsh Menon <harsh@nod-labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for batch dimensions.
They can be specified in the vector_shapes dict
with a shape of 0 with a corresponding workgroup
constraint. This specifies that we want to distribute the batch dim among workgroups, but not among threads.