Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test experiments #224

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Hardcode84
Copy link
Contributor

No description provided.

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@@ -19,7 +16,8 @@ concurrency:

jobs:
test:
name: "Unit Tests and Type Checking"
name: "Perf Tests"
if: ${{ github.event.issue.pull_request }} && contains(github.event.comment.body, '/turbine_run_perf')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to look for a label being applied or validate the author of the comment somehow. This looks like any GitHub user (project member or not) could trigger the workflow by adding this comment. That increases the surface area for malicious behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doesn't work anyway yet :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just probably create separate personal repo and experiment on it first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iree-org/iree/blob/7d60397cbe62e8563a36ec286c41aa40d7e4e58d/.github/workflows/benchmark_trigger.yml might also be useful to reference (I'm sure there are other good references in other github projects, but that's what we used in iree-org/iree for a while)

Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants