Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to torch < 2.5.0 #228

Closed
wants to merge 1 commit into from

Conversation

marbre
Copy link
Member

@marbre marbre commented Oct 18, 2024

The CPU requirements restrict torch to a version < 2.5.0, whereas the ROCm requirements did not so far. The current iree-turbine is incompatible with torch 2.5.0 as torch.export.dynamic_dim() was removed with pytorch/pytorch@b454c51.

Closes #227

The CPU requirements restrict torch to a version < 2.5.0, whereas the
ROCm requirements did not so far. The current iree-turbine is
incompatible with torch 2.5.0 as `torch.export.dynamic_dim()` was
removed with pytorch/pytorch@b454c51.

Closes #227
@Hardcode84
Copy link
Contributor

Does it work? I've tried this some time ago and they weren't providing 2.4 nightlies anymore.

@marbre
Copy link
Member Author

marbre commented Oct 18, 2024

Does it work? I've tried this some time ago and they weren't providing 2.4 nightlies anymore.

I didn't tested for nightlies, but that is what we're doing here already:

torch>=2.3.0, <2.5.0

@Hardcode84
Copy link
Contributor

pytorch-rocm-requirements.txt uses different channel: https://download.pytorch.org/whl/nightly/rocm6.0

@marbre
Copy link
Member Author

marbre commented Oct 18, 2024

Seems the main issue is that there are no 2.4.* nighties for ROCm: https://download.pytorch.org/whl/nightly/rocm6.0/torch

@marbre marbre closed this Oct 18, 2024
@marbre marbre deleted the users/marbre/pytorch-rocm-requirements branch October 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants