Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elementwise and broadcast simulator tests #56

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add elementwise and broadcast simulator tests #56

merged 1 commit into from
Jul 31, 2024

Conversation

Hardcode84
Copy link
Contributor

@Hardcode84 Hardcode84 commented Jul 29, 2024 •
edited
Loading

As I'm using torch.tensor in simulator, all elementwise ops and broadcasting should work out of the box.

@Hardcode84
add elementwise and broadcast simulator tests
16eb5bd 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
harsh-amd
harsh-amd approved these changes Jul 31, 2024
View reviewed changes
Copy link

@harsh-amd harsh-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests. Great that broadcasting just works out of the box.

tests/kernel/wave/wave_sim_test.py Show resolved Hide resolved
tests/kernel/wave/wave_sim_test.py


def test_broadcast_1():
# Input sizes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

harsh-nod
harsh-nod approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@harsh-nod harsh-nod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@Hardcode84 Hardcode84 merged commit 5e28a8e into iree-org:main Jul 31, 2024
5 of 7 checks passed
@Hardcode84 Hardcode84 deleted the sim-tests branch July 31, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-nod harsh-nod harsh-nod approved these changes

@harsh-amd harsh-amd harsh-amd approved these changes

@martin-luecke martin-luecke Awaiting requested review from martin-luecke

@raikonenfnu raikonenfnu Awaiting requested review from raikonenfnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hardcode84 @harsh-nod @harsh-amd