Skip to content

Commit

Permalink
[GPU][NFC] Update comments for MMAAttr attribute (#18339)
Browse files Browse the repository at this point in the history
The revision redirects the layout comment to the enum file which reduces
the maintenance burden. People wont miss to update comments like this.
IMO, it is also the naming convention, so we don't need to spell it
loud.

The revision also make the "section comment" consistent.
  • Loading branch information
hanhanW authored Aug 23, 2024
1 parent 70d212b commit e3936dc
Showing 1 changed file with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ class IREEGPU_MmaVectorLayoutAttr<string attrname, string mmaintrinsic> :

//===----------------------------------------------------------------------===//
// MMA intrinsic
//===----------------------------------------------------------------------===//

class IREEGPU_MmaEnumAttr<EnumAttrInfo enumInfo, string name = "">
: EnumAttr<IREEGPU_Dialect, enumInfo, name>;
Expand All @@ -186,12 +187,8 @@ def IREEGPU_MMAAttr : IREEGPU_MmaVectorLayoutAttr<"MMA", "MMAIntrinsicAttr"> {
let description = !strconcat(baseDescription, [{
This mma variant describes configurations for MMA ops. The |intrinsic|
field specifies which particular MMA intrinsic this refers to, with each
intrinsic implicating a specific MNK shape and operand types. The intrinsic
enum name describes these fields as

<InputType>_MxNxK_<CType>

Where the element type for the `A` and `B` matrices are both `InputType`.
intrinsic implicating a specific MNK shape and operand types.
See IREEGPUEnums.td for the definition of the intrinsics.
}]);

let hasCustomAssemblyFormat = 1;
Expand Down Expand Up @@ -230,6 +227,7 @@ def IREEGPU_MMAOpsArrayAttr : ArrayOfAttr<

//===----------------------------------------------------------------------===//
// MMA schedule
//===----------------------------------------------------------------------===//

def IREEGPU_MmaScheduleAttr : AttrDef<IREEGPU_Dialect, "MMASchedule"> {
let mnemonic = "mma_schedule";
Expand Down Expand Up @@ -259,6 +257,7 @@ def IREEGPU_MmaScheduleAttr : AttrDef<IREEGPU_Dialect, "MMASchedule"> {

//===----------------------------------------------------------------------===//
// Workgroup processor level description
//===----------------------------------------------------------------------===//

def IREEGPU_TargetWgpAttr : AttrDef<IREEGPU_Dialect, "TargetWgp"> {
let summary = "Workgroup processor level target description";
Expand Down

0 comments on commit e3936dc

Please sign in to comment.